Browse Source

Merge pull request #24177 from ATM-Consulting/FIX_16.0_expensereport_add_ndf

Fix expensereport add ndf
Laurent Destailleur 2 years ago
parent
commit
0028ca6fb6
1 changed files with 2 additions and 2 deletions
  1. 2 2
      htdocs/expensereport/class/expensereport_ik.class.php

+ 2 - 2
htdocs/expensereport/class/expensereport_ik.class.php

@@ -198,9 +198,9 @@ class ExpenseReportIk extends CommonObject
 		$default_range = (int) $userauthor->default_range; // if not defined, then 0
 		$default_range = (int) $userauthor->default_range; // if not defined, then 0
 		$ranges = $this->getRangesByCategory($fk_c_exp_tax_cat);
 		$ranges = $this->getRangesByCategory($fk_c_exp_tax_cat);
 		// prevent out of range -1 indice
 		// prevent out of range -1 indice
-		$indice = $default_range > 0 ? $default_range - 1 : 0;
+		$indice = $default_range  - 1;
 		// substract 1 because array start from 0
 		// substract 1 because array start from 0
-		if (empty($ranges) || !isset($ranges[$indice])) {
+		if (empty($ranges) || $indice < 0 || !isset($ranges[$indice])) {
 			return false;
 			return false;
 		} else {
 		} else {
 			return $ranges[$indice];
 			return $ranges[$indice];