Browse Source

Fix missing return

Laurent Destailleur 2 years ago
parent
commit
05307c6667
1 changed files with 8 additions and 4 deletions
  1. 8 4
      htdocs/mailmanspip/class/mailmanspip.class.php

+ 8 - 4
htdocs/mailmanspip/class/mailmanspip.class.php

@@ -287,8 +287,8 @@ class MailmanSpip
 	 *  Subscribe an email to all mailing-lists
 	 *
 	 *	@param	Adherent	$object		Object with data (->email, ->pass, ->element, ->type)
-	 *  @param	array	$listes    	To force mailing-list (string separated with ,)
-	 *  @return	int		  			<0 if KO, >=0 if OK
+	 *  @param	array		$listes    	To force mailing-list (string separated with ,)
+	 *  @return	int		  				<0 if KO, >=0 if OK
 	 */
 	public function add_to_mailman($object, $listes = '')
 	{
@@ -306,7 +306,7 @@ class MailmanSpip
 			return -1;
 		}
 
-		if ($conf->adherent->enabled) {	// Synchro for members
+		if (isModEnabled('adherent')) {	// Synchro for members
 			if (!empty($conf->global->ADHERENT_MAILMAN_URL)) {
 				if ($listes == '' && !empty($conf->global->ADHERENT_MAILMAN_LISTS)) {
 					$lists = explode(',', $conf->global->ADHERENT_MAILMAN_LISTS);
@@ -347,6 +347,8 @@ class MailmanSpip
 				return -1;
 			}
 		}
+
+		return 0;
 	}
 
 	// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
@@ -374,7 +376,7 @@ class MailmanSpip
 			return -1;
 		}
 
-		if ($conf->adherent->enabled) {	// Synchro for members
+		if (isModEnabled('adherent')) {	// Synchro for members
 			if (!empty($conf->global->ADHERENT_MAILMAN_UNSUB_URL)) {
 				if ($listes == '' && !empty($conf->global->ADHERENT_MAILMAN_LISTS)) {
 					$lists = explode(',', $conf->global->ADHERENT_MAILMAN_LISTS);
@@ -415,5 +417,7 @@ class MailmanSpip
 				return -1;
 			}
 		}
+
+		return 0;
 	}
 }