Browse Source

Fix warnings

Laurent Destailleur 1 year ago
parent
commit
da1d622f80
29 changed files with 136 additions and 31 deletions
  1. 5 0
      htdocs/core/class/commondocgenerator.class.php
  2. 5 0
      htdocs/core/modules/asset/modules_asset.php
  3. 5 0
      htdocs/core/modules/barcode/modules_barcode.class.php
  4. 5 0
      htdocs/core/modules/bom/modules_bom.php
  5. 5 0
      htdocs/core/modules/cheque/modules_chequereceipts.php
  6. 5 0
      htdocs/core/modules/commande/modules_commande.php
  7. 5 0
      htdocs/core/modules/delivery/modules_delivery.php
  8. 5 0
      htdocs/core/modules/dons/modules_don.php
  9. 5 2
      htdocs/core/modules/expensereport/modules_expensereport.php
  10. 5 2
      htdocs/core/modules/facture/modules_facture.php
  11. 5 2
      htdocs/core/modules/fichinter/modules_fichinter.php
  12. 5 2
      htdocs/core/modules/hrm/modules_evaluation.php
  13. 4 0
      htdocs/core/modules/member/modules_member.class.php
  14. 5 2
      htdocs/core/modules/mrp/modules_mo.php
  15. 6 0
      htdocs/core/modules/payment/modules_payment.php
  16. 5 0
      htdocs/core/modules/product_batch/modules_product_batch.class.php
  17. 4 4
      htdocs/core/modules/project/modules_project.php
  18. 5 0
      htdocs/core/modules/project/task/modules_task.php
  19. 5 2
      htdocs/core/modules/propale/modules_propale.php
  20. 6 0
      htdocs/core/modules/stocktransfer/modules_stocktransfer.php
  21. 5 2
      htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php
  22. 5 2
      htdocs/core/modules/supplier_order/modules_commandefournisseur.php
  23. 5 2
      htdocs/core/modules/supplier_payment/modules_supplier_payment.php
  24. 5 2
      htdocs/core/modules/supplier_proposal/modules_supplier_proposal.php
  25. 5 2
      htdocs/core/modules/takepos/modules_takepos.php
  26. 5 2
      htdocs/core/modules/ticket/modules_ticket.php
  27. 5 2
      htdocs/core/modules/workstation/modules_workstation.php
  28. 0 1
      htdocs/recruitment/core/modules/recruitment/modules_recruitmentjobposition.php
  29. 1 0
      phpstan.neon

+ 5 - 0
htdocs/core/class/commondocgenerator.class.php

@@ -40,6 +40,11 @@ abstract class CommonDocGenerator
 	 */
 	public $name = '';
 
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/asset/modules_asset.php

@@ -101,6 +101,11 @@ abstract class ModelePDFAsset extends CommonDocGenerator
  */
 abstract class ModeleNumRefAsset
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/barcode/modules_barcode.class.php

@@ -52,6 +52,11 @@ abstract class ModeleBarCode
  */
 abstract class ModeleNumRefBarCode
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/bom/modules_bom.php

@@ -67,6 +67,11 @@ abstract class ModelePDFBom extends CommonDocGenerator
  */
 abstract class ModeleNumRefBoms
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/cheque/modules_chequereceipts.php

@@ -36,6 +36,11 @@ require_once DOL_DOCUMENT_ROOT.'/compta/bank/class/account.class.php'; // Requis
  */
 abstract class ModeleNumRefChequeReceipts
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/commande/modules_commande.php

@@ -85,6 +85,11 @@ abstract class ModelePDFCommandes extends CommonDocGenerator
  */
 abstract class ModeleNumRefCommandes
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/delivery/modules_delivery.php

@@ -70,6 +70,11 @@ abstract class ModelePDFDeliveryOrder extends CommonDocGenerator
  */
 abstract class ModeleNumRefDeliveryOrder
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 0
htdocs/core/modules/dons/modules_don.php

@@ -66,6 +66,11 @@ abstract class ModeleDon extends CommonDocGenerator
  */
 abstract class ModeleNumRefDons
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 2
htdocs/core/modules/expensereport/modules_expensereport.php

@@ -110,13 +110,16 @@ function expensereport_pdf_create(DoliDB $db, ExpenseReport $object, $message, $
 
 abstract class ModeleNumRefExpenseReport
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *	Return if a model can be used or not

+ 5 - 2
htdocs/core/modules/facture/modules_facture.php

@@ -253,13 +253,16 @@ abstract class ModelePDFFactures extends CommonDocGenerator
  */
 abstract class ModeleNumRefFactures
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 * Return if a module can be used or not

+ 5 - 2
htdocs/core/modules/fichinter/modules_fichinter.php

@@ -67,13 +67,16 @@ abstract class ModelePDFFicheinter extends CommonDocGenerator
  */
 abstract class ModeleNumRefFicheinter
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 * 	Return if a module can be used or not

+ 5 - 2
htdocs/core/modules/hrm/modules_evaluation.php

@@ -66,13 +66,16 @@ abstract class ModelePDFEvaluation extends CommonDocGenerator
  */
 abstract class ModeleNumRefEvaluation
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *	Return if a module can be used or not

+ 4 - 0
htdocs/core/modules/member/modules_member.class.php

@@ -67,6 +67,10 @@ abstract class ModelePDFMember extends CommonDocGenerator
  */
 abstract class ModeleNumRefMembers
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
 
 	public $code_modifiable; // Editable code
 

+ 5 - 2
htdocs/core/modules/mrp/modules_mo.php

@@ -67,13 +67,16 @@ abstract class ModelePDFMo extends CommonDocGenerator
  */
 abstract class ModeleNumRefMos
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *	Return if a module can be used or not

+ 6 - 0
htdocs/core/modules/payment/modules_payment.php

@@ -23,11 +23,17 @@
 
 abstract class ModeleNumRefPayments
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
+
 	/**
 	 *	Return if a module can be used or not
 	 *

+ 5 - 0
htdocs/core/modules/product_batch/modules_product_batch.class.php

@@ -69,6 +69,11 @@ abstract class ModelePDFProductBatch extends CommonDocGenerator
  */
 abstract class ModeleNumRefBatch
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 4 - 4
htdocs/core/modules/project/modules_project.php

@@ -121,14 +121,14 @@ abstract class ModelePDFProjects extends CommonDocGenerator
 abstract class ModeleNumRefProjects
 {
 	/**
-	 * @var string Error code (or message)
+	 * @var string Version
 	 */
-	public $error = '';
+	public $version = '';
 
 	/**
-	 * @var string $version
+	 * @var string Error code (or message)
 	 */
-	public $version;
+	public $error = '';
 
 	/**
 	 *  Return if a module can be used or not

+ 5 - 0
htdocs/core/modules/project/task/modules_task.php

@@ -66,6 +66,11 @@ abstract class ModelePDFTask extends CommonDocGenerator
  */
 abstract class ModeleNumRefTask
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */

+ 5 - 2
htdocs/core/modules/propale/modules_propale.php

@@ -86,13 +86,16 @@ abstract class ModelePDFPropales extends CommonDocGenerator
  */
 abstract class ModeleNumRefPropales
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 * Return if a module can be used or not

+ 6 - 0
htdocs/core/modules/stocktransfer/modules_stocktransfer.php

@@ -67,11 +67,17 @@ abstract class ModelePDFStockTransfer extends CommonDocGenerator
  */
 abstract class ModeleNumRefStockTransfer
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
+
 	/**
 	 *	Return if a module can be used or not
 	 *

+ 5 - 2
htdocs/core/modules/supplier_invoice/modules_facturefournisseur.php

@@ -66,13 +66,16 @@ abstract class ModelePDFSuppliersInvoices extends CommonDocGenerator
  */
 abstract class ModeleNumRefSuppliersInvoices
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**  Return if a model can be used or not
 	 *

+ 5 - 2
htdocs/core/modules/supplier_order/modules_commandefournisseur.php

@@ -88,13 +88,16 @@ abstract class ModelePDFSuppliersOrders extends CommonDocGenerator
  */
 abstract class ModeleNumRefSuppliersOrders
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**  Return if a model can be used or not
 	 *

+ 5 - 2
htdocs/core/modules/supplier_payment/modules_supplier_payment.php

@@ -94,13 +94,16 @@ abstract class ModelePDFSuppliersPayments extends CommonDocGenerator
 
 abstract class ModeleNumRefSupplierPayments
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *	Return if a module can be used or not

+ 5 - 2
htdocs/core/modules/supplier_proposal/modules_supplier_proposal.php

@@ -69,13 +69,16 @@ abstract class ModelePDFSupplierProposal extends CommonDocGenerator
  */
 abstract class ModeleNumRefSupplierProposal
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 * Return if a module can be used or not

+ 5 - 2
htdocs/core/modules/takepos/modules_takepos.php

@@ -33,14 +33,17 @@
  */
 abstract class ModeleNumRefTakepos
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
 
-	public $version = '';
-
 	/**
 	 * Return if a module can be used or not
 	 *

+ 5 - 2
htdocs/core/modules/ticket/modules_ticket.php

@@ -60,13 +60,16 @@ abstract class ModelePDFTicket extends CommonDocGenerator
  */
 abstract class ModeleNumRefTicket
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *  Return if a module can be used or not

+ 5 - 2
htdocs/core/modules/workstation/modules_workstation.php

@@ -67,13 +67,16 @@ abstract class ModelePDFWorkstation extends CommonDocGenerator
  */
 abstract class ModeleNumRefWorkstation
 {
+	/**
+	 * @var string Version
+	 */
+	public $version = '';
+
 	/**
 	 * @var string Error code (or message)
 	 */
 	public $error = '';
 
-	public $version;
-
 
 	/**
 	 *	Return if a module can be used or not

+ 0 - 1
htdocs/recruitment/core/modules/recruitment/modules_recruitmentjobposition.php

@@ -37,7 +37,6 @@ require_once DOL_DOCUMENT_ROOT.'/compta/bank/class/account.class.php'; // requir
  */
 abstract class ModelePDFRecruitmentJobPosition extends CommonDocGenerator
 {
-
 	/**
 	 * @var int page_largeur
 	 */

+ 1 - 0
phpstan.neon

@@ -48,6 +48,7 @@ parameters:
 		- '#Undefined variable: \$error#'
 		- '#Undefined variable: \$errors#'
 		- '#Undefined variable: \$form#'
+		- '#Caught class Stripe#
 	internalErrorsCountLimit: 50
 	cache:
 	    nodesByFileCountMax: 512