浏览代码

Fix regression on vat calculation when invoice was not a situation
invoice

Laurent Destailleur 9 年之前
父节点
当前提交
f345ff7300
共有 2 个文件被更改,包括 7 次插入5 次删除
  1. 4 3
      htdocs/accountancy/journal/sellsjournal.php
  2. 3 2
      htdocs/compta/journal/sellsjournal.php

+ 4 - 3
htdocs/accountancy/journal/sellsjournal.php

@@ -142,13 +142,14 @@ if ($result) {
 		// Situation invoices handling
 		$line = new FactureLigne($db);
 		$line->fetch($obj->fdid); // id of line
-		$prev_progress = $line->get_prev_progress($obj->rowid);   // id of invoice
+		$prev_progress = 0;
 		if ($obj->type == Facture::TYPE_SITUATION) {
-			// Avoid divide by 0
+		    // Avoid divide by 0
 			if ($obj->situation_percent == 0) {
 				$situation_ratio = 0;
 			} else {
-				$situation_ratio = ($obj->situation_percent - $prev_progress) / $obj->situation_percent;
+		        $prev_progress = $line->get_prev_progress($obj->rowid);   // id of invoice
+			    $situation_ratio = ($obj->situation_percent - $prev_progress) / $obj->situation_percent;
 			}
 		} else {
 			$situation_ratio = 1;

+ 3 - 2
htdocs/compta/journal/sellsjournal.php

@@ -167,13 +167,14 @@ if ($result)
 		// Situation invoices handling
 		$line = new FactureLigne($db);
 		$line->fetch($obj->id);   // id of line
-		$prev_progress = $line->get_prev_progress($obj->rowid);   // id on invoice
+		$prev_progress = 0;
 		if ($obj->type==Facture::TYPE_SITUATION) {
 			// Avoid divide by 0
 			if ($obj->situation_percent == 0) { 
 				$situation_ratio = 0;
 			} else {
-				$situation_ratio = ($obj->situation_percent - $prev_progress) / $obj->situation_percent;
+		        $prev_progress = $line->get_prev_progress($obj->rowid);   // id on invoice
+			    $situation_ratio = ($obj->situation_percent - $prev_progress) / $obj->situation_percent;
 			}
 		} else {
 			$situation_ratio = 1;